Skip to content

DEVDOCS-6188: [update] Login with JWT #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

DEVDOCS-6188: [update] Login with JWT #882

merged 3 commits into from
Apr 8, 2025

Conversation

bc-traciporter
Copy link
Contributor

@bc-traciporter bc-traciporter commented Mar 27, 2025

DEVDOCS-6188

What changed?

Describe the two options for logging in using a JWT

Release notes draft

Anything else?

ping {names}

@bc-traciporter bc-traciporter requested a review from 6juara9 March 27, 2025 14:59
@bc-traciporter bc-traciporter marked this pull request as ready for review March 27, 2025 15:07
Copy link
Contributor

@6juara9 6juara9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think we need to change our structure a little bit, we can use this one as a reference: https://developer.bigcommerce.com/docs/start/authentication/customer-login or even make some adjustments there: basic idea is that we use the same JWT token in loginWithCustomerLoginJwt mutation as we use in customer-login endpoint aka /login/token/{token}. It is generated by 3rd parties and everything is already described, we just need to provide some infromation about loginWithCustomerLoginJwt mutation there, that it is an alternative to HTTP endpoint 🙂

@bc-traciporter bc-traciporter added the ready for review This PR is complete and awaiting a review. label Apr 7, 2025
Copy link
Contributor

@bc-terra bc-terra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bc-traciporter bc-traciporter merged commit 8d93942 into main Apr 8, 2025
3 checks passed
@bc-traciporter bc-traciporter deleted the DEVDOCS-6188 branch April 8, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is complete and awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants